lift clauses in LogicalAst #2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
approved these changes
Jul 5, 2024
fulmicoton
requested changes
Jul 5, 2024
fulmicoton
reviewed
Jul 5, 2024
| // If clauses below have the same `Occur`, we can pull them up | ||
| match simplified_sub_ast { | ||
| LogicalAst::Clause(sub_clauses) | ||
| if sub_clauses.iter().all(|(o, _)| *o == occur) => |
There was a problem hiding this comment.
What if Occur is Not?
Can we stay on the safe side and only apply this logic for occur = Must, Should, or Filter?
Also this will only yield the same score if we sum scores of child branches.
(I think this is the case today: we don't rely on dismax do we?)
There was a problem hiding this comment.
yes good catch, I excluded it and added a test. There are more optimization we can do here to flatten clauses later on
(a OR b) OR (c OR d) can be simplified to (a OR b OR c OR d) (a AND b) AND (c AND d) can be simplified to (a AND b AND c AND d) This directly affects how queries are executed remove unused SumWithCoordsCombiner the number of fields is unused and private
trinity-1686a
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
I believe other simplifications are possible (see below), this one seems correct
- top: Should, inner: single Must => Should
- top: Must, inner: single Should => Must
top: MustNot, inner: all MustNot => all Shouldimpact scoring (or we need to wrap with a boost of 0)- top: MustNot, inner: single Must|Should => MustNot
- top: Must, inner: all MustNot => all MustNot
|
@trinity-1686a Can you open a ticket and auto-assign for this? |
fulmicoton
approved these changes
Jul 29, 2024
philippemnoel
pushed a commit
to paradedb/tantivy
that referenced
this pull request
Aug 31, 2024
(a OR b) OR (c OR d) can be simplified to (a OR b OR c OR d) (a AND b) AND (c AND d) can be simplified to (a AND b AND c AND d) This directly affects how queries are executed remove unused SumWithCoordsCombiner the number of fields is unused and private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(a OR b) OR (c OR d) can be simplified to (a OR b OR c OR d)
(a AND b) AND (c AND d) can be simplified to (a AND b AND c AND d)
This directly affects how queries are executed and the performance
Remove
SumWithCoordsCombiner, it is effectively the same asSumCombiner, but with an unused field